Hello neilwatson,

IIRC those numbers are octal, but if I wrap them in oct() test 3 fails.

You have to remove the leading zero when wrapping in oct():

 1:53 >perl -wE "say 022;"
18

 1:53 >perl -wE "say oct(22);"
18

 1:53 >perl -wE "say oct(022);"
Illegal octal digit '8' ignored at -e line 1.
1

 1:53 >

[download]

(Otherwise the argument to oct is converted from octal to decimal before it’s passed to oct.) So using:

my $mode = $sb[2] & oct(777);
...
ok( ! ( $mode & oct(22) ), "File is not group or world writable" );

[download]

should make Perl::Critic happy. :-)

Update: Alternatively, you can stringify the argument to oct and leave the leading zero in place:

 1:53 >perl -wE "say oct('022');"
18

 2:08 >

[download]

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: Perlcritic and checking file modes by Athanasius
in thread Perlcritic and checking file modes by neilwatson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.