Removing most of the '->'s is a good idea. You could also remove 26 single-quotes (around all the literal key names) and a pair of double-quotes. Splitting the assignment over two lines gives a maximum line length of 80 characters (previously 156). I think that provides additional readability. 

my %shortlist;
for my $key (keys $results->{ALLHOSTS}) {
    for my $key2 (keys $results->{ALLHOSTS}{$key}{ports}{tcp}) {
        $shortlist{$results->{ALLHOSTS}{$key}{ports}{tcp}{$key2}{servi
+ce}{name}}
            = $results->{ALLHOSTS}{$key}{ports}{tcp}{$key2}{state};
    }
}

[download]

[Note: as I'm editing untested code, mine is also untested.]

Update: I've also added spaces before the opening braces of the for blocks: I think that makes those a little clearer.

-- Ken

In reply to Re^4: Parsing output from Nmap::Scanner with varying hash address. by kcott
in thread Parsing output from Nmap::Scanner with varying hash address. by mopmeat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.