Aside from your immediate problem, there are a few things that will help write robust file handling code now and in the future.

First, always use strictures (use strict; use warnings; - see The strictures, according to Seuss).

Use the three parameter version of open and lexical file handles:

my $path = "$dir/$entry"; open my $inFile, '<', $path, or die "Can't open '$path': $!\n";

Checking that an entry is a file before trying to open it will save failures, especially for . and .. directory entries which are present in each directory on common file systems.

Your code is better written:

use strict; use warnings; use 5.010; my $startDir = "/temp/"; opendir my ($dir), $startDir or die "cannot open '$startDir'\n"; while (defined (my $entry = readdir $dir)) { my $path = "$dir/$entry"; next if !-f $path; open my $inFile, '<', $path, or die "Can't open '$path': $!\n"; print <$inFile>; }

Note that lexical file and directory handles close when they go out of scope so explicit closes are not needed in this code. Also note that including file or directory information and the failure mode in a die makes the error reporting much more useful.

Premature optimization is the root of all job security

In reply to Re: File handling basics by GrandFather
in thread File handling basics by ElectroRed

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.