Hi guys this is my first post and I've only recently started learning perl so please be gentle. I'm not new to programming but am currently working at a company that uses perl to automate some financial business, my job is to refactor old code because some of it is outdated/not used anymore or could look a little more friendly to the user. My question is with the following code snippet: 
$who = "su_and_it";
$subject = "Error processing $filename";
$severity = 3;
$message = "Server: $server\n";
$message = $message."File: $origfile\n";
$message = $message."Error: Departments missing from WWMBR_NAMES.TXT";
$othercontact = "None";
$path = $work_dir;
$file = $missingdeptfilename;

&ampNotify($othercontact,$who, $severity,$subject,$message,$path,$file
+);

[download]
Does it make sense to create these variables and immediately pass them into this subroutine right after? Or should I change the subroutine arguments to just be the values themselves? I feel like creating the variables prior calling the subroutine clutters the code (note that this snippet appears all over the entire set of perl automation but with a few interchanged arguments). Do you have any tips on how to approach this problem? Also, I would greatly appreciate any tips on refactoring perl code in general, methodologies or processes that you may have used before to approach it. I ask because it'll help me develop good scripting practice and also because this is slightly overwhelming to just tackle. Thanks for any help!

In reply to Creating Variables Just to Pass into Subroutine? by mdskrzypczyk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.