Hello,

refactoring inherited code can be scary, unless you have a good set of tests for all the use cases the code needs to handle. Think of it as a safety net before you start. Also, a version control system would be useful in case of unintentional destructive changes...

So this should be the foundation to build on and the first step.

Once you have that, I would start refactoring with the help of Damian Conways' book 'Perl best practices' and the Perl-Critic tool. Keep the amount of changes small and focused, and retest often. Always before checking into version control.

Regarding your code snippet: assigning one variable to another one at least has the benefit of having more meaningful variable names (which makes it more user friendly, but is a bit redundant). Why not use good names in the first place?

Passing subroutine parameters in a hash, where the keys name the parameters, can also yield readable code, since the names are part of the subroutine interface then.

I hope this helps a bit.

In reply to Re: Creating Variables Just to Pass into Subroutine? by hexcoder
in thread Creating Variables Just to Pass into Subroutine? by mdskrzypczyk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.