Well... probably the best way to store a regex is qr...
$regex = qr/(test)foo/i; #then to use it $var =~ $regex;
you can store a regex string in a variable as so
$regex = '(test)foo'; #but then to call it you must do $var =~ /$regex/;
now, the first way is much better usually, especially if you use that pattern more than once, since it only has to compile once.

I would do...

#!/usr/bin/perl -w $log=qr/(.*)\s+-\s+-\s+\[(\d+)\/(\w+)\/(\d+):(\d+):(\d+)/; $log=qr/(\d+):(\d+):(\d+)\s+(\d+\.\d+\.\d+\.\d+)\s/ if $ARGV[2] eq 'ii +s'; $document=qr/report.html\?/; $document2=qr/secret.html\?/; # open the log file - the log file we want to check out open(LOG, "<$ARGV[0]") || die("Could not open $ARGV[0] : $!"); # open our Report file - the file we will write out report to open(REPORT, ">$ARGV[1]") || die("Could not open $ARGV[1] : $!"); while(<LOG>){ if($_ =~ $document){ ($ip, $day, $month, $year, $hr, $min) = ($_ =~ $log); $totaldoc++; print REPORT "Access on doc1 from: $ip on $month $day at $hr:$ +min\n"; } elsif($document2){ $totaldoc2++; print REPORT "Access on doc2 from: $ip on $month $day at $hr:$ +min\n"; } } print REPORT "Total doc1: $totaldoc\n"; print REPORT "Total doc2: $totaldoc2\n"; close(LOG); close(REPORT);
now if your third arg is iis, it will parse iis logs, otherwise it will do apache... that help? Of course, it would not be a bad idea to use strict, either...

                - Ant
                - Some of my best work - Fish Dinner


In reply to Re: question about regex and using a scalar variable to store/call it by suaveant
in thread question about regex and using a scalar variable to store/call it by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.