You never declare and define getvalue1. This:

getvalue1{
    print "$email : $token";
}

[download]

...should be this...

sub getvalue1{
    print "$email : $token";
}

[download]

And your print statement probably would be better with a newline appended to the end:

    print "$email : $token\n";

[download]

Another note: Though you are using lexical variables (my variables), you aren't using them effectively. One place where your use of lexicals could be improved upon is in how you pass values into subroutines. Instead of absorbing $email and $token into getvalue1(), pass values in:

sub getvalue1{
    my ($e, $t) = @_;
    print "$e : $t\n";
}

[download]

...and invoke the subroutine like this:

getvalue1($email, $token);

[download]

In a small script like this it's not a big win, but in larger scripts (more than, say 100 lines), it becomes untenable trying to follow how a global variable's state gets manipulated throughout the course of the script. By keeping variable scopes small, and decoupling subroutines from the environment around them, you minimize action at a distance, and make it much easier to comprehend the program's logic, flow, and state.


Dave

In reply to Re: Undefined subroutine &main:: by davido
in thread Undefined subroutine &main:: by alokranjan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.