"i look forward to learn how to make it more elegant with map and grep."

You appear to be assuming that using map and/or grep will automatically make your code more elegant. This is not the case.

The code you already have is easy to read (and therefore maintain) and its intent is clear. I can't say the same for these map/grep alternatives:

print $_->[0] for grep { @{$_->[1]} } map { [ $_, [ grep { $_ eq $search } @{$hash->{$_}{member}} ] ] } keys %$hash;
print $_->[0] for grep { $_->[1] } map { [ $_, scalar grep { $_ eq $search } @{$hash->{$_}{member}} ] } keys %$hash;

Furthermore, for loops are often faster. Benchmark to check this with whatever alternative solution(s) you might be considering.

Here's my test code:

#!/usr/bin/env perl -l use strict; use warnings; my $hash = { A => { member => [qw{q w e}], }, B => { member => [qw{a s d}], }, C => { member => [qw{q a z}], }, }; my $search = 'q'; print 'OP Solution:'; for my $hk (keys %$hash) { for my $m (@{$hash->{$hk}{member}}) { if ($m eq $search) { print $hk; } } } print 'map/grep Solution 1'; print $_->[0] for grep { @{$_->[1]} } map { [ $_, [ grep { $_ eq $search } @{$hash->{$_}{member}} ] ] } keys %$hash; print 'map/grep Solution 2'; print $_->[0] for grep { $_->[1] } map { [ $_, scalar grep { $_ eq $search } @{$hash->{$_}{member}} ] } keys %$hash;

Output:

OP Solution: A C map/grep Solution 1 A C map/grep Solution 2 A C

— Ken


In reply to Re: howto map/grep a complex structure by kcott
in thread howto map/grep a complex structure by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.