I'll take a closer look later when I have more time, but I didn't realize you were doing substitution regexes. For that, you either have to use eval or here are two other methods that I know how to get around the eval call.

Force the caller to pass in a code reference with the entire details of the substitution...

my $str = "This is one thing. This.";

sub cref_regex {
    my ($str, $re_cref) = @_;
    print $re_cref->($str);
}

my $cref = sub { $_[0] =~ s/This/That/ig; };

cref_regex($str, $cref);

[download]

...or, force the caller to send in both a $search and if required, an optional $replace variable...

sub separate_regex {
    my ($str, $search, $replace) = @_;

    if (! $replace){
        print $str =~ /$search/;
    }
    else {
        print $str =~ s/$search/$replace/g;
    }
}

separate_regex($str, 'This', 'That');

[download]

Both of those are more work for the caller, so I can't tell which is better in the long run. I've just always heard "don't use string eval", so I try to avoid it where possible.

In a recent module of mine I updated, I opted for the $search, $replace option.

-stevieb

In reply to Re^3: Generic Parsing class with callback by stevieb
in thread Generic Parsing class with callback by QuillMeantTen

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.