You probably want to use a hash instead. Create a key for each zipcode by assigning it the value of 1, then see if the zipcode you're checking has a key in the hash.

#!/usr/bin/perl use strict; use warnings; my $file = "zipcodes.txt"; my %zipcodes; open (my $fh, '<', $file) or die "Can't open $file for read: $!"; while (<$fh>) { chomp; $zipcodes{$_}++; } close $fh or die "Cannot close $file: $!"; while (chomp( my $line = <STDIN> )) { print "found $line\n" if $zipcodes{ $line }; } __END__
Don't forget to chomp the lines as you read them from the file, and from STDIN.

Edit: If you want to be lazy, you can use a module to open, read and close your file, do the chomping for you and put the lines in a list. In the snippet below we use Path::Tiny, which allows us to write one line to return a list of zip codes and map them into the hash:

use Path::Tiny; my $file = 'index.txt'; my %zipcodes = map { $_, 1 } path( $file )->lines({chomp => 1});
More simply, this is how to get the list of chomped lines:
my @lines = path( $file )->lines({chomp => 1});

Hope this helps!

The way forward always starts with a minimal test.

In reply to Re: regex matching array values with foreach by 1nickt
in thread regex matching array values with foreach by jasper8989

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.