Welcome back to Perl!
While you were away, the best practice for using open has improved and it is now strongly recommended to use lexical filehandles and the three-argument version of open. In other words, instead of saying
open (FH, "< $file") or die "Can't open $file for read: $!";
it's better to use
open (my $fh, "<", $file) or die "Can't open $file for read: $!";
In the new version,
$fh is scoped like a regular variable (in the old way,
FH is global) and passing
< and
$file as separate parameters helps to prevent some types of potential attacks by malicious users.
Also, a couple other general tips, which hopefully won't add to your confusion:
- To read in all the lines of your zipcode file, you can use my @zipcodes = <$fh>; instead of the while loop.
- You can combine all the zipcodes into a single regular expression with my $zip_re = join '|', @zipcodes; and then test each $line against that single regex instead of looping through @zipcodes each time.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.