tye, I just wanted to thank you for your direct criticism of the code you saw. When I set out to build this module, I wanted to test new things, but at the same time, ensure a flow that was single-path as much as possible, so I could collect and manage the data flowing through the chain at any point. It was, until I started peppering my code with Tie::File all over the place, which completely broke the flow.

Right or wrong, what I've been doing today is rewriting all of the off-flow cases. The read/write of actual files happen now in a read sub and a write sub. There's only one place where each of these subs is called (from the single sub that interacts between the public methods and the core of the system upon entering and returning), so I've already found troubleshooting is much easier, as is making changes, validation, and handling line endings properly all in one place.

I've always said since I started here at PM that "I am not a programmer", but even though we all feel a bit of shame when people point out our mistakes, I for one get past that and realize that those who reply actually care, and I for one definitely learn from it.

Thanks again,

-stevieb


In reply to Re^8: CPAN module unit test issues: OS line endings (topic) by stevieb
in thread CPAN module unit test issues: OS line endings by stevieb

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.