Yes, you should probably consider using
Getopt::Long.
But, as for your script, it seems that the problem is the following:
if (@ARGV > 0) {
if ( $ARGV[0] eq "-c") {
if ( ! -e "$ARGV[1]" ) {
print "Provided xml file doesnot exists\n";
}
elsif ( -f "$ARGV[1]") {
$controlfile = $ARGV[1];
parse_xml();
update_exports();
}
}
else { #...
If
(@ARGV > 0), then the number or arguments should really be 2 (you need 0 or 2 arguments, the option and the file name), so that if
(@ARGV == 1) (only one argument) it is also an error, but your code is not checking that, hence the problem when you pass the option flag but not the file name.
In brief, if (@ARGV > 0), then you should check that you have (@ARGV == 2), or else call the usage() sub.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.