I have no OO techniques to suggest, just write clearer code.

Don't repeat yourself so much. This :-

        if ($intermediate_array[12] eq "GSM" && $intermediate_array[9]
+ eq "MSubmit")
        {
            $intermediate_MO_cnt++;
        }
        if ($intermediate_array[12] eq "GSM" && $intermediate_array[9]
+ eq "MSubmit" && $intermediate_array[7] eq "MsgAccepted")
        {
            $total_MO_success++;
        }

[download]

could be written as :-

    if ($intermediate_array[12] eq "GSM" && $intermediate_array[9] eq 
+"MSubmit") {

        $intermediate_MO_cnt++;
        if ( $intermediate_array[7] eq "MsgAccepted") {
            $total_MO_success++;
        }
    }

[download]

It's clearer and easier to see what your intent was, and there are fewer places for bugs to hide.

Variable names like $del_user1_error , $del_user2_error, .. $del_userN_error are always a sign that you should have used any array and you're writing too much code. So instead you could do something like this :-

    my @del_user_error_count;

    for my $i (0..4) {
        if ($cdr_post_array[11] eq $del_user_errors[$i]) {
            $del_user_error_count[$i]++;
            last;
        }
    }

[download]

In reply to Re: Making program readable by RichardK
in thread Making program readable by ravi45722

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.