G'day Cody Fendant,

I would keep the base operations separate and clearly named to indicate their functions:

This allows you to unambiguously call the method you want directly and get feedback for errors.

For your "either add or update" function, what you're doing is modifying your set of widgets. I'd give it a name that exactly reflects that:

$self->modify_widget_set($id, @other_args)

This would call either add_widget() or update_widget() depending on the existence of $id in the database.

The method names I've shown are just suggestions. I'm not a big fan of CamelCase; however, if this is already used throughout your codebase, it would make sense to stick with it (addWidget(), modifyWidgetSet(), etc.).

"Would you call it just widget()?"

Short answer: Never!

Longer answer: Subroutines do something and their names should reflect this. Use verbs (or, at least, something suggesting a verb).

— Ken


In reply to Re: Subroutine naming convention/style by kcott
in thread Subroutine naming convention/style by Cody Fendant

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.