You're iterating over the list of files twice, once in the grep & once in the foreach, and you don't need to do that. Also glob is easier to use than opendir/readdir, IMHO. So you could have done something like this

use v5.20;
use warnings;
use autodie qw/:all/;
use File::Glob qw/:bsd_glob/;
use File::Spec;
use File::Basename;


sub showtree {
  my ($dir,$indent) = @_;
  $indent .= '  ';
  my @list = bsd_glob(File::Spec->catfile($dir,'*'));
  foreach my $f (@list) {
    if (-d $f) {
      say $indent,'+-',basename($f);
      showtree($f,$indent . '|');
    }
    if (-l $f) {
      say $indent,'+-',basename($f),' --> ',readlink($f);
    }
  }
}

showtree($ARGV[0] // '.');

[download]

In reply to Re: tree command by RichardK
in thread tree command by Skeeve

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.