That script looks to be written in a quite old style of Perl, and it doesn't make use of any standard modules where it could, and could take a lot of clean up work to bring it up to modern standards. Sure, it could be modified*, but it might not hurt to take a step back:

The goal is to avoid using switches when invoking /usr/bin/vncserver

Are you sure that's the easiest solution to the problem (which you haven't described)? It requires you to maintain a patched version of a script you don't fully understand. Why not just write a small wrapper shell script around vncserver?

#!/bin/sh /usr/bin/vncserver -geometry 2000x1200 # ... etc

* Quick & dirty example (requires Config::Tiny):

use Config::Tiny; my $cfg = Config::Tiny->read("$ENV{HOME}/.vnc/config"); $geometry = $cfg->{_}{geometry} if exists $cfg->{_}{geometry};

Just enough rope ;)


In reply to Re: Like to modify /usr/bin/vncserver to parse a config file by Anonymous Monk
in thread Like to modify /usr/bin/vncserver to parse a config file by gsky

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.