return join " ", grep {$_ <= $n} @primes;

This use of grep will iterate over the entire list of  @primes even after the  $n limit is encountered. This is not a problem for a list of the first fifteen primes, but might be for the first 15 million primes! One way to mitigate this overhead would be with the List::MoreUtils::last_index() function:

c:\@Work\Perl\monks>perl -le "use warnings; use strict; ;; use List::MoreUtils qw(last_index); ;; my @primes = (2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47) +; print qq{primes: @primes}; ;; sub listprimes { my ($n) = @_; ;; my $last_i = last_index { $_ <= $n } @primes; ;; return join ' ', @primes[ 0 .. $last_i ]; } ;; sub random { my ($lo, $hi) = @_; return $lo + int rand $hi - $lo + 1; } ;; for (1 .. 5) { my $r = random(10, 50); my $f = listprimes($r); print qq{r == $r: $f}; } " primes: 2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 r == 50: 2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 r == 32: 2 3 5 7 11 13 17 19 23 29 31 r == 18: 2 3 5 7 11 13 17 r == 47: 2 3 5 7 11 13 17 19 23 29 31 37 41 43 47 r == 25: 2 3 5 7 11 13 17 19 23


Give a man a fish:  <%-{-{-{-<


In reply to Re^2: Perl program - I hope I can more understand my code by AnomalousMonk
in thread Perl program - I hope I can more understand my code by brianphan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.