Hello QuillMeantTen,

If you see ... things that can be made better, do post about them ...

This sub caught my eye:

sub printattr{
    my $file = shift;
    my @fileattr = split(//,(stat($file))[2]);
    print "[";
    for my $attr (@fileattr){
        if($attr eq 0){
            print "---";
        }
        elsif($attr eq 1){
            print "--x";
        }
        elsif($attr eq 2){
            print "-w-";
        }
        elsif($attr eq 3){
            print "-wx";
        }
        elsif($attr eq 4){
            print "r--";
        }
        elsif($attr eq 5){
            print "r-x";
        }
        elsif($attr eq 6){
            print "rw-";
        }
        else{
            print "rwx"
        }
    }
    print "]\n";
}
[download]

It can be written more succinctly using an array (or, better, a persistent array reference) for lookup:

use feature 'state';

sub printattr
{
    state $attrs = [ qw( --- --x -w- -wx r-- r-x rw- rwx ) ];
    state $maxi  = $#$attrs;
    my   ($file) = @_;

    print '[';
    print $attrs->[$_ < $maxi ? $_ : $maxi] for split //, (stat $file)
+[2];
    print "]\n";
}
[download]

Update: Since each array index is limited to the range 0 .. 9, it’s simpler and more efficient to just extend the array:

sub print_attr
{
    state $attrs = [ qw( --- --x -w- -wx r-- r-x rw- rwx rwx rwx) ];
    my   ($file) = @_;

    print '[';
    print $attrs->[$_] for split //, (stat $file)[2];
    print "]\n";
}
[download]

Hope that’s of interest,

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.