Other Monks have pointed out the errs in your ways, so I won't go there, I'll just expand... I would personally use Archive::Extract so your code doesn't have to shell out. Said module has been part of perl's core since pre-v5.10. Also note that I use a file glob (<*.ext>) to slurp in the file names, which retain their full path information (this eliminates another system call (ls)). Here's an example:

use warnings;
use strict;

use Archive::Extract;

my $inputs = "~/inputs";
my $results = "/home/steve/results";

my @files = <$inputs/*.tar.gz>;

for (@files){
    my $ae = Archive::Extract->new(archive => $_);

    $ae->extract(to => $results)
      or die "couldn't decompress the damned $_ file!: " . $ae->error;

    print "decompressed $_\n";
}

[download]

For some reason, extract() wouldn't recognize the homedir shortcut, so I just entered in the full path. I'm sure it can expand it somehow, I just don't have the time to troubleshoot.

In reply to Re: foreach loop to untar multiple files by stevieb
in thread foreach loop to untar multiple files by fasoli

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.