Hello msh210,

The logic of your while loop condition is too complicated. Rearranging and simplifying, I came up with this, which seems to do what you want:

#! perl
use strict;
use warnings;

use constant
{
    DELAY  =>   10,
    EXPIRY => 3600,
    MARGIN =>  300,
};

my $time   =  time;
my $expiry = $time + EXPIRY;

while ($time + MARGIN < $expiry)
{
    my $previoustime = $time;
    warn $time;

    sleep DELAY + $previoustime - $time
        unless $time - $previoustime >= DELAY;

    $time = time;
}

[download]

Output:

16:17 >perl 1453_SoPW.pl
1447741073 at 1453_SoPW.pl line 18.
1447741083 at 1453_SoPW.pl line 18.
1447741093 at 1453_SoPW.pl line 18.
1447741103 at 1453_SoPW.pl line 18.
1447741113 at 1453_SoPW.pl line 18.
...

[download]

A side note: sleep returns the number of seconds slept (as an integer). So the condition:

( $time - $previoustime >= 10
  or sleep (10 + $previoustime - $time)
)

[download]

could evaluate to zero — which is false — causing the loop to terminate prematurely. In my testing I don’t see this happening, but it’s still a logic error (a potential bug), and so a further reason to simplify the logic of the loop condition.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: while loop acting up, though I'm not sure how by Athanasius
in thread while loop acting up, though I'm not sure how by msh210

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.