Hello cbtshare, and welcome to the Monastery!

Further to 1nickt’s post, if you open a file with +>> as the mode, the filehandle’s position is set to the end of the file. To read from the beginning, you need to add a seek:

seek XML, 0, 0;

However, as 1nickt says, this won’t solve the problem. You want to update passwords within the file, and appending new data at the end of the file can’t accomplish that.

One approach is to use the core module Tie::File:

use strict; use warnings; use Tie::File; my $filename = ...; tie my @array, 'Tie::File', $filename or die "Cannot tie file '$filename' to array: $!"; for my $line (@array) { my $newline = $line; # Make a copy while ($line =~ / Name=(.*?) \s+ Password=(.*?) (?:\s+|$) /gx) { my $name = $1; my $password = $2; print "Enter the plain text password for $name, ", "password is currently '$password'\n"; chomp(my $newpass = <>); print "You will now swap $password for Password='$newpass'\n"; print "Continue? (y/n)\n"; chomp(my $answer = <>); # Change the copy $newline =~ s{Password=\Q$password\E}{Password=$newpass} if $answer =~ /y/i; } $line = $newline; # Update this line in the file } untie @array or die "Cannot untie file '$filename': $!";

Note that it’s necessary to make the progressive password substitutions to a copy of $line, because changing $line within the while loop resets the /g match position, resulting in an infinite loop. See, e.g., “Global matching” in Using regular expressions in Perl.

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re: Script won't run by Athanasius
in thread Script wont run by cbtshare

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.