my $array_ref = {};
push(@$array_ref, {});

[download]
The code above, which is part of your second example, gives an error because $array_ref = {} initializes your $array_ref to a hash ref which is not compatible as the first argument of push. It may be sort of symptomatic of your programming difficulties in that initializing $array_ref to a hash ref is confusing and just looks like code that is headed off in the wrong direction. I think your examples add more complication than needed and, for me, trying to simplify gives a result like: 
use strict;
use warnings;

sub foo {
    my %hash = ();
    ....
    %hash = ....  # key/values populated by some API

    bar(\%hash);
}

sub bar {
    my $hash_ref = shift;
    my @arr_of_href = $hash_ref;
    
    foreach my $i (.....) {
       ....  %some_hash initialized here for each iteration of the for
+ loop
       push (@arr_of_href, \%some_hash); 
    }

    zzz(\@arr_of_href);   # zzz() will do something with this array
}

[download]
Ron

In reply to Re: Best practices for passing in function arguments? by mr_ron
in thread Best practices for passing in function arguments? by andrewkl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.