The x operator does not work that way. Consider this: 

#!/bin/env perl
use strict;
use warnings;
use Data::Dumper;

my @records = ( ['value1', 'value2'], ['value3', 'value4'], ['value5',
+ 'value6']);

my @broken = ('( ?, ? )' x @records);
print 'broken: ', Dumper \@broken;

my @fixed = ('( ?, ? )') x @records;
print 'fixed: ', Dumper \@fixed;
__DATA__
broken: $VAR1 = [
          '( ?, ? )( ?, ? )( ?, ? )'
        ];
fixed: $VAR1 = [
          '( ?, ? )',
          '( ?, ? )',
          '( ?, ? )'
        ];

[download]

This example leads us to the corrected line of your original code: 

my $values = join ", ", ("( ?, ? )") x @records;

[download]

In reply to Re: Proper Syntax for DBI multiple row insert by Mr. Muskrat
in thread Proper Syntax for DBI multiple row insert by Rodster001

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.