Hello again Tara,

You have the line:

$final_data = ` grep "$key_pattern" "${indir}/${lkp_file_name}" |cut -
+d"|" -f"$data_location"`;

[download]

Here is one way to write this in pure Perl (untested):

my $file = $indir . '/' . $lkp_file_name;

open(my $fh, '<', $file)
    or die "Cannot open file '$file' for reading: $!";

my @matched_lines = grep { /\Q$key_pattern/ } <$fh>;

close $fh
    or die "Cannot close file '$file': $!";

my @fields;

for my $line (@matched_lines)
{
    my    $field = (split /\|/, $line)[$data_location - 1];
    chomp $field;
    push  @fields, $field;
}

$final_data = join "\n", @fields;

[download]

(There should also be some error handling to deal with the possibility that a matched line contains an insufficient number of fields.)

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re^3: Perl Script performance issue by Athanasius
in thread Perl Script performance issue by Tara

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.