I have following code in a big build system inherited from somewhere. It's not only deprecated but nowadays it errors out and the "no strict" is a no go afaik. 
sub PkgContains
{
  my ($package, $sub) = @_;    # Return TRUE if $package contains $sub
  no strict;

  local(*pkg_symtab) = eval("*${package}::");
  return 0 unless defined(%pkg_symtab);
  return defined($pkg_symtab{$sub});
}

[download]
I changed it to this: 
sub PkgContains
{
  my ($package, $sub) = @_;    # Return TRUE if $package contains $sub
  no strict;

  local(*pkg_symtab) = eval("*${package}::");
  if (exists $pkg_symtab{$sub}){
    return defined($pkg_symtab{$sub});
  }else{
    return 0;
  }
}

[download]
My perl skills are very low so now the questions. What does the code do at all, do my changes make sense and how to improve this? I'm asking because I get an error with one of my make targets which didn't appear before the deprecate warning for "defined(%pkg_symtab)" went to be an error. Thanks in advance and regards, Uli

In reply to error defined on hash by audiomobster

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.