Side comments on the SQL itself.

Dynamic SQL is not a good idea. The script uses EXECUTE IMMEDIATE, whose documentation warns of SQL Injection right on top. Though, dealing with owner names like this limits the alternatives. Anyway, there are other statements here that can clearly use placeholders.

SELECT * should not really be used outside of EXISTS() and ad hoc queries. Listing the column names directly is self-documenting, and protects against column changes or reordering.

A sub-query inside the ORDER BY clause is probably not the most efficient method. Are you sure that is the best way to do it?

Personally, when i wanted to report on a few instances of Oracle, i installed XE locally and created DB Links to each. Then, reporting on them was both safe and easy.

In reply to Re: Perl script to check database works or does it? by chacham
in thread Perl script to check database works or does it? by chris01010

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.