Glad you got it working. Couple of suggestions:
-
You should always use strict; and use warnings; at the top of your code; Perl provides built-in code validation and it's silly not to use it. One day (many days) it will save your ass.
-
You should check to see whether opening a file succeeded.
-
You should only declare a variable in the smallest scope possible.
-
You might look into Perltidy for help on your code style, which is hard to read and inconsistent. Suggested edit:
#!/bin/perl
use strict;
use warnings;
my @months = ('', qw/jan feb mar apr may jun jul aug sep oct nov dec/)
+;
print($_, "\t") for @months;
print "\n";
my (%report, $cust);
open(my $DATA, '<', 'sales.txt') or die "Open failed: $!";
while (<$DATA>) {
chomp;
if ( /^[A-Z]/ ) {
$cust = $_;
@{ $report{$cust} } = map { 0 } @months;
next;
}
my ($date, $value) = split ' ', $_;
my ($mon, $year) = split '/', $date;
$report{$cust}[$mon] = $value;
}
foreach my $cust (keys %report) {
print $keys,"\t";
print($report{$cust}[$_], "\t") for 0 .. 12;
}
print "\n";
One of the benefits of clear syntax is that it enables you to spot typos, such as the stray
}
print "\n";
in your code above.
Hope this helps!
The way forward always starts with a minimal test.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.