A couple of things, first is just a matter of preference, but on this:
open FILE, "$dir\\$file" or die "Can't open $dir\\$file: $!";

[download]
I find the double backslashes ugly, and on Windows you can pretend you have a Unix file system, and just use a single forward slash, which looks alot better IMHO.

Second, correct me if I'm wrong, but I don't see any variables in your $target, $target2, or $replace variables, which makes them constant strings, and as such I would define them outside the loop, and on your substitution statement I would use the '/o' modifier (see perldoc perlre).

Last, you're checking the status of your opendir and your first open, which is good, but your not checking the status of your lastopen, which is bad.

Update: Also, use 'here docs', e.g.:

my $target = <<ENDHTML;
<html>
<head>
<title>[^>]*</title>
<meta
 http-equiv="Content-Type" content="text/html;charset=iso-8859-1">
</head>
<body bgcolor=["]#FFFFFF["]>
ENDHTML

[download]

In reply to Re: One-shot code critique by runrig
in thread One-shot code critique by patgas

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.