Hello thomasd

your XML has the </MsgSigs> closing tag missing.. corrected this I as always propose an XML::Twig based solution. Infact navigation methods as summarized here (the site has also good tutorials!) make the life of an XML traveller easier.

Note also that twig_handlers plus flush make the program very memory efficient: for every xdoc/MsgSigs/MsgSig two child are inspected and the first manipulated, then flush prints all the twig parsed till now and memory is freed.

#!perl
use strict;
use warnings;

use XML::Twig;
my $t= XML::Twig->new(pretty_print => 'indented',
   twig_handlers=>{
                    'xdoc/MsgSigs/MsgSig'=>sub{
                     my $keytext = $_[1]->first_child('Key')->text;
                     my $descrtext = $_[1]->first_child('Description')
+->text;
                     $_[1]->first_child('Description')->set_text($desc
+rtext." ($keytext)");
                     $_[0]->flush;
                   }
   }
);
$/='';
$t->parse(<DATA>);
__DATA__
<xdoc>
  <MsgSigs>
   <MsgSig>
     <Description>TSC1 - Torque/Speed Cntrl 1</Description>
     <Key>ln1</Key>
     <XtdFrame>True</XtdFrame>
     <NetworkKey>net0</NetworkKey>
     <MsgSignals>
     </MsgSignals>
   </MsgSig>
   <MsgSig>
     <Description>TSC1 - Torque/Speed Cntrl 1</Description>
     <Key>ln2</Key>
     <XtdFrame>True</XtdFrame>
     <NetworkKey>net0</NetworkKey>
     <MsgSignals>
        <Signal>
          <Description>0_SPN695 Eng. Override </Description>
          <Key>sig695</Key>
          <ValueType>1</ValueType>
        </Signal>
     </MsgSignals>
   </MsgSig>
  </MsgSigs>
</xdoc>


###OUTPUT
<xdoc>
  <MsgSigs>
    <MsgSig>
      <Description>TSC1 - Torque/Speed Cntrl 1 (ln1)</Description>
      <Key>ln1</Key>
      <XtdFrame>True</XtdFrame>
      <NetworkKey>net0</NetworkKey>
      <MsgSignals></MsgSignals>
    </MsgSig>
    <MsgSig>
      <Description>TSC1 - Torque/Speed Cntrl 1 (ln2)</Description>
      <Key>ln2</Key>
      <XtdFrame>True</XtdFrame>
      <NetworkKey>net0</NetworkKey>
      <MsgSignals>
        <Signal>
          <Description>0_SPN695 Eng. Override </Description>
          <Key>sig695</Key>
          <ValueType>1</ValueType>
        </Signal>
      </MsgSignals>
    </MsgSig>
  </MsgSigs>
</xdoc>

[download]

HtH

L*

There are no rules, there are no thumbs..
Reinvent the wheel, then learn The Wheel; may be one day you reinvent one of THE WHEELS.

In reply to Re: Appending Text of One XML Node to that of the Other -- XML::Twig by Discipulus
in thread Appending Text of One XML Node to that of the Other by thomasd

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.