The signaling code is pretty awful. Lots of unnecessary locking and unlocking, and it's far more complicated than it needs to be. Here it is improved:
use threads; use threads::shared; use Thread::Queue; my $a :shared = 0; my $q = Thread::Queue->new(); sub set_positive { lock $a; while (1) { cond_wait($a) while $a > 0; $a = int(rand() * 100) + 1; cond_signal($a); $q->enqueue($a); } } sub set_zero { lock $a; while (1) { cond_wait($a) while $a == 0; $a = 0; cond_signal($a); $q->enqueue($a); } } sub printer { while (1) { my ($v_a, $v_b) = $q->dequeue(2); print "At printer $v_a $v_b\n"; } } threads->create($_) for qw( set_positive set_zero printer); $_->join for threads->list;
cond_wait should always be used as cond_wait($lock) while !desired_condition();.
cond_signal (or cond_broadcast) is used when you change something checked by a thread's desired_condition().
Remember, your lock is released when you call cond_wait, and re-obtained before cond_wait returns.
In reply to Re^2: Threads sharing global variable
by ikegami
in thread Threads sharing global variable
by Anonymous Monk
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |