should a subroutine do one thing and one thing well rather than trying to combine both subroutines into one because of the common code between them

Why not both? :) You don't show us an example of the calling code, but it sounds like get_ticket could call "do_request", which returns the data structure, but get_ticket could extract just the ticket ID (scalar) and return that: 

sub get_ticket {
  my $data = do_request(@_);
  if ($data) {
    return $data->{ticket_ID};
  }
  return; # error?
}

[download]

As for variable names ... I like to keep my functions in other namespaces - put all your REST calls into a single module, and then the fact the names look the same wouldn't really matter, and having them have the same names can sometimes be an advantage.

In reply to Re: subroutine and good practices by Tanktalus
in thread subroutine and good practices by jmsnet

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.