There are several problems in your code. The main problem is the /g on line 21: it's called in scalar context, so it remembers where the search stopped, and the next matching (line 22) starts there. The single [R] before UNREMARKABLE is therefore skipped.

Your comment rightly indicates the second if is almost the same as the first one. Usually, one would abstract the common behaviour into a subroutine. Using the name OUTPUT for an input handle is a bit confusing, too (and lexical filehandles are safer than barewords). Here's my take:

#!/usr/bin/perl use warnings; use strict; sub process_column { my ($patient, $column, $fh_out) = @_; if ($column =~ m/\[R\]/) { if (my @vars = $column =~ m/\](.*?)\[/g) { for my $var (@vars) { if ($var !~ /^\s+$/g) { print {$fh_out} "$patient || $var\n"; } } } } } open my $OUTFILE, '<', 'C:/Scripts/TEST/History21.txt' or die "Could not open source file. $!"; open my $NEW_MED, '>', 'C:/Scripts/TEST/History_MED1.txt' or die "Could not open target file. $!"; open my $NEW_SUR, '>', 'C:/Scripts/TEST/History_SUR1.txt' or die "Could not open target file. $!"; my $count = 1; while (my $line = <$OUTFILE>) { my @rows = split /\|\|/, $line; process_column($rows[0], $rows[1], $NEW_MED); process_column($rows[0], $rows[2], $NEW_SUR); $count++; } close $NEW_SUR or die "Cannot close target file: $!"; close $NEW_MED or die "Cannot close target file: $!"; print "COUNT: $count\n";

($q=q:Sq=~/;[c](.)(.)/;chr(-||-|5+lengthSq)`"S|oS2"`map{chr |+ord }map{substrSq`S_+|`|}3E|-|`7**2-3:)=~y+S|`+$1,++print+eval$q,q,a,

In reply to Re: Extracting multiple match with regex by choroba
in thread Extracting matches using boundries with regex by NewMonk2Perl

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.