In addition to the excellent points made by GrandFather++, you should be aware that merely putting your code into a package does not make it a class. See perlootut.

Another point: my @fields = ... declares a lexical variable with scope limited to the surrounding while loop. So, when the loop exits, the variable goes out of scope and its data are lost. Worse, the variable is re-defined on each iteration of the loop, so its previous contents are overridden. You need something along these lines:

my @fields;

while (<IN>)
{
    chomp;
    push @fields, split /\t/;
}

# @fields is still in scope

[download]

See push. And, of course, the variable @text is used without being declared.

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re: creating a class with encapsulation ? by Athanasius
in thread creating a class with encapsulation ? by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.