It does seem very complicated :) Can't you just use the Unix sort command to sort the files?

And I think you may have made a mistake when copying your code into this post. What you have there doesn't compile - it is missing a closing brace somewhere.

Update: I think there was a paste error in the code. A large chunk of the code was repeated. He's what I think the code should look like (Note: I've reformatted it a bit, but haven't made any fixes yet)

#!/usr/local/bin/perl -w

use strict;
$| = 1;
use diagnostics;

####################################################################
##  This file is designed to reorder the log files for the corporate
##  web server.  These log files will be sequentially ordered for
##  faster parsing.
####################################################################

my $existingLogFile;
my $newLogFile      = "$existingLogFile"."_sorted";
my $logdirs         = "/data/sortlogs/";
my @unique;
my $counter = 0;
my @timestamps;

opendir (LOGDIR, $logdirs) or die "no $logdirs: $!";
while ($_ = readdir(LOGDIR)) {
  if ($_ =~ /^access/) {
    $existingLogFile = $_;
  }
}

open (EXFILE, $existingLogFile)
  or die "Could not open $existingLogFile $!";

while (<EXFILE>) {
  if (/^\d/) {
    chomp;
    my ($begOfLog, $timeString, $endOfString) = split /[\[\]]/, $_;
    push (@timestamps, $timeString);
  }
}
close (EXFILE);

@timestamps = sort (@timestamps);
$unique[0] = $timestamps[0];
foreach my $stamp(@timestamps) {
  unless ($stamp eq $unique[$counter]) {
    push (@unique, $stamp);
    $counter++;
  }
}

foreach my $ts (@unique) {
  open (SORTEDFILE, ">>$newLogFile")
    or die "Could not open $newLogFile $!\n";
  open (EXFILE, "+<$existingLogFile")
    or die "Could not open $existingLogFile $!";

  while (<EXFILE>) {
    my ($before, $entryStamp, $after) = split /[\[\]]/, $_;
    my $strippedEntry = tell(EXFILE);
    if ($ts eq $entryStamp) {
      print SORTEDFILE $_;
    } else {
      open (TEMPFILE, ">>/data/temp")
        or die "Couldn't open temp file $!\n";
      print TEMPFILE $_;
    }
  }
  close (EXFILE);
  close (SORTEDFILE);
  close (TEMPFILE);
  rename ("/data/temp",$existingLogFile);
}

[download]
--
<http://www.dave.org.uk>

"The first rule of Perl club is you don't talk about Perl club."

In reply to Re: Slow but it works by davorg
in thread Slow but it works by scottstef

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.