It is slow probably because you seem to be doing an awful lot of reading and writing. An example log entry would have helped, but the following (with the addition of the appropriate checking) will create the log file on sorted order without a temp file and without readin the whole file into memory.

my $MAXBUFLEN = 1024 * 1024; # 1M

sub sort_logfile {
  my $file = shift;
  my @off = (0);
  my @lines;
  open(INFILE, "<$file");
  while(<INFILE>) {
    push @off, tell;
    if (/^\d.*?\[([^\]]+)\]/) {
      push @lines, [$1, $.-1];
    }
    else {
      # assume any non-matching line
      # is a continuation of the previous
      $off[-2] = $off[-1];
      next;
    }
  }

  @lines = sort { $a->[0] cmp $b->[0] } @lines;

  open(INFILE,"<$file");

  my $line = 0;
  my $buf;
  while (my $i = shift @lines) {
    my ($start, $end) = ($i->[1],$i->[1]+1);
    while( @lines and $lines[0]->[1] == $end) {
      shift @lines;
      $end++;
    }
    ($start,$end) = @off[$start,$end];
    my $len = $end - $start;
    while ($len > 0) {
      seek(INFILE, $start, 0) or die "seek: $!";
      read(INFILE, $buf='', $len > $MAXBUFLEN ? $MAXBUFLEN : $len)
        or die "read: $!";
      print $buf;
      $len -= length $buf;
    }
  }
}

[download]

In reply to Re: Slow but it works by gbarr
in thread Slow but it works by scottstef

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.