Yes, actually $attached is a single string whether $code is true or false: in the latter case, it’s the empty string. And that means you get a key/value pair in which the string $attached is the key, and the value is undef — which gives the “Odd number of elements” warning.

The solution is to eval the string:

#! perl
use strict;
use warnings;
use Data::Dump;

my $body      = 'Hello!';
my $code      =  1;
my $email     = 'addressee';
my $file_name = 'unknown';
my $from      = 'sender';
my $name      = 'A Nonny Mouse';
my $subject   = 'Greeting';
my $attached  =  $code ? "attach_path     => '$file_name', " .
                         "attach_filename => '$file_name', " .
                         "attach_type     => 'application/txt'," : '';

my $success =
   {
       to        => $email,
       from      => $from,
       from_name => $name,
       subject   => $subject,
       body      => $body,
       eval $attached,
   };

dd $success;

[download]

Output:

 2:21 >perl 1655_SoPW.pl
{
  attach_filename => "unknown",
  attach_path => "unknown",
  attach_type => "application/txt",
  body => "Hello!",
  from => "sender",
  from_name => "A Nonny Mouse",
  subject => "Greeting",
  to => "addressee",
}

 2:21 >

[download]

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re^3: Odd number of elements in anonymous hash by Athanasius
in thread Odd number of elements in anonymous hash by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.