croak "end of file" unless $n;Does that sound reasonable?
Reasonable, if a little unfriendly.
I wonder whether you might change it so that that at end of file, it returns whatever it got:
sub get {
my($self) = shift;
my($len) = @_;
my($x, $n, $o) = ("", 0, 0);
my($sock) = $$self;
do {
$n = $sock->sysread($x, $len - $o, $o);
croak $! unless defined $n;
$o += $n;
} until $o == $len or $n == 0;
return $x;
}
But maybe there is no circumstance in which getting less than is expected (how does it know how much to expect?) is a recoverable error?
With the rise and rise of 'Social' network sites: 'Computers are making people easier to use everyday'
Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
In the absence of evidence, opinion is indistinguishable from prejudice.
Not understood.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.