Seems a waste to copy the sql from, e.g., $self->{SQL}->{test} to $self->{test}, and I would assume $self is already a closure, so you shouldn't need to pass it to the sub, and the sth itself can be a closure and so not stored directly in $self, so I might go with:
for ( keys %{$self->{SQL}} ) {
  my $name = $_;
  my $dbh = $self->{DBO};
  my $sth = $dbh->prepare($self->{SQL}{$name};
  $self->{STH}{$name} = sub {
    my @res;
    $sth->execute(@_);
    while (my $dbrow = $sth->fetchrow_hashref()) {
      # Not sure why you're making a reference to a hashref here
      push @res, \$dbrow;
    }  
    return \@res;
  };
}

[download]
And if you don't need to have references to hashrefs in the arrayref, then the execute() and the while loop can be replaced with:
my $res = $dbh->selectall_arrayref($sth, {Slice => {}}, @_);
return $res;

[download]
Or even (only $sth needs to be a closure):
return $sth->{Database}->selectall_arrayref($sth, {Slice => {}}, @_);

[download]

In reply to Re: naming anonymous subroutines inner variables by runrig
in thread naming anonymous subroutines inner variables by writch

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.