First off, take a hard look at your nested loop. It may help to rewrite it a little to see what's going on:

foreach $name (@name) { last if ($name =~ $filename); unlink($files . "\\" . $filename) or warn qq{cannot delete $filename: $!+}; last; }

which is the same as:

if ($name[0] !~ $filename) { unlink($files . "\\" . $filename) or warn qq{cannot delete $filename: $!+}; }

because the two uses of last mean that you only ever get 1 iteration of the nested loop. That code ensures you delete the current file unless the first name happens to match the current file name.

However when you want to answer a "is it in the set" question use a hash. Consider:

#!\perl\bin\perl use strict; use warnings; my $files = "C:\\Directory"; my $list = "C:\\Test.sdf"; my %keepList; open my $namesIn, '<', $list or die "Failed to open file: $!\n"; while (<$namesIn>) { chomp; $keepList{$_} = 1; } close $namesIn; opendir my ($filesScan), $files; while (my $filename = readdir $filesScan) { next if exists $keepList{$filename}; unlink "$files\\$filename" or warn qq{cannot delete $filename: $!+ +}; } closedir $filesScan;

Note that I haven't tested the code!

Premature optimization is the root of all job security

In reply to Re: Compare 2 arrays by GrandFather
in thread Compare 2 arrays by niceguy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.