I liked your code. A few suggestions, but also not tested!
- Use "/" instead of "\\" for windows file paths
- I think some extra filtering is necessary on the $namesIn file?
- for opendir, add a die message if fails
- for readdir, skip all but simple files - maybe here makes no difference, but I would do it.
Perhaps something like this???
#!usr/bin/perl
use strict;
use warnings;
my $files = "C:/Directory";
my $list = "C:/Test.sdf";
my %keepList;
open my $namesIn, '<', $list or die "Failed to open file: $!\n";
# minor updates to this loop #####################
while (my $line = <$namesIn>) #updated #######
{
my $sdf_file;
#next unless ($sdf_file) = $line =~ /(\w+\.nfo)"$/;
#this regex should work equally well
next unless ($sdf_file) = $line =~ /(\w+\.nfo)/;
$keepList{$sdf_file} = 1;
print "keeping $sdf_file\n"; #update for debugging #######
}
close $namesIn;
opendir my ($filesScan), $files or die "unable to open dir $!";
while (my $filename = readdir $filesScan)
{
next unless -f "$files/$filename"; #only simple files allowed
#skip . and .. or other dirs
next if exists $keepList{$filename};
unlink "$files/$filename" or warn qq{cannot delete $filename: $!+}
+;
}
closedir $filesScan;
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.