fellow monks-
i am writing this query as more of a "did i do this correctly?" rather than a "how do i...?".
the code i am working with involved a fairly lengthy subroutine, which i have since broken into two subs as the newest revision of the code added too much and made readability taxing.
however, i now find that a variable called in the first routine, and declared with my $error is to be used in the second routine. since i am using use strict; i receive a complaint that $error in the second routine needs to be declared. the snippet of my code is:

sub exec {
...
    ## retrieve an error message if unsuccessful
    my $error = $s->error
      if ($count > 0);
    ## log this action
    &log_action('error')
      if ($count > 0);
...
}

[download]

now the log_action subroutine has the following line:

sub log_action {
my $i = shift;

  if ($i eq "error") {
    print "\n$error\n\n";
    print FH "$format $error";
...
}

[download]

i fixed this by just removing the my localization for $error outside of the subroutine to a global statement of my $error; earlier in the script. however, i just dont like the look of this declaration standing all by its lonesome. is there another/better method of passing the value of $error from subroutine to subroutine?

humbly -c

In reply to passing a variable from one subroutine to another by c

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.