I'll agree with Zaxo on the fact that you shouldn't be using reserved words as variables/sub names. As far as using local to scope a global, most people recommend against using it since it can confuse the flow of a program. Though using it is fully valid if you want to make your $error a global. I would suggest the following solution: 
sub execute {
  my $error = $s->$error if ($count > 0);
  ## log this action
  &log_action($error) if ($count > 0);
  # just pass the $error var to &log_action
}

sub log_action {
  my $i = shift;

  if ($i) {
    print "\n$i\n\n";
    print FH "$format $error";
  }
}

[download]
Hope that does the trick for you.

BlackJudas

In reply to Re: passing a variable from one subroutine to another by blackjudas
in thread passing a variable from one subroutine to another by c

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.