add the element number to the array slice, and update the equal-to count number.

Whenever a single change requires two (or more) synchronised updates to the code, this is a bug waiting to happen.

In this case, we can take advantage of the fact that “all x are y” is logically equivalent to “it is not the case that any x is not y.” That is, we can eliminate the duplication by negating both the condition and the if statement:

use strict;
use warnings;

my @array = qw( 0 0 7 abc 0 );

for my $i ([0, 1, 4], [0, 1, 3, 4], [1], [], [2])
{
    print "(@array[ @$i ]): ";

    if (grep !/^0$/, @array[ @$i ])  # !/^0$/ would be better as $_ ne
+ '0'
    {
        print "not all are zero\n";
    }
    else
    {
        print "all are zero\n";
    }
}

[download]

Output:

 1:40 >perl 1692_SoPW.pl
(0 0 0): all are zero
(0 0 abc 0): not all are zero
(0): all are zero
(): all are zero
(7): not all are zero

 1:40 >

[download]

Hope that helps,

Athanasius <°(((>< contra mundum Iustus alius egestas vitae, eros Piratica,

In reply to Re^2: Check multiple array elements for a single condition by Athanasius
in thread Check multiple array elements for a single condition by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.