Fixed multiple syntax errors, and added code to parse the new $code value.

#/usr/bin/perl
use strict;
use warnings;
my $code = 'ITEM_1 ,ITEM_2 ,ITEM_3 ,ITEM_4 ,ITEM_5 ,ITEM_6';
my $dir = '/local/usr/prod/';
my $exp = 'PRODUCTS';

for my $c (split /[\s,]+/, $code){
    my @filelist =glob "$dir*$c*$exp*failed*";
    foreach my $oldname (@filelist){
        next if -d $oldname; # Update - corrected this - was missing $
+oldname!
        (my $newname = $oldname) =~ s/sold/ordered/;
        rename $oldname,$newname
            or warn "can't rename $oldname to $newname: $!"
    }
}
[download]

You should consider using @ARGV to pass arguments into your program. see perlvar.

---

In reply to Re: Perl Rename set of files by NetWallah
in thread Perl Rename set of files by Magnolia25

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.