First an answer to your question.

No, you probably don't need a flock. On Unix I can guarantee that you don't if your strategy for rewriting the file is to write it to a different name and then rename the new one on top of the old. Otherwise the worst that can happen is a low likelyhood of a page from time to time which is somewhat truncated. (If you do flock, make it a shared lock.)

However you do have many other things about your coding style that could be worked on. For instance a function with return in the name suggests that you are returning stuff. You are not, so the name should better reflect what you are doing. Also it is good to break out argument processing so that it is obvious from a glance what arguments your subroutine takes. And it would be good to do more separation of content and presentation. Aggressively inlined HTML makes both program logic and layout harder to see and manipulate...

In reply to Re (tilly) 1: Do I need to give a flock? by tilly
in thread Do I need to give a flock? by jerrygarciuh

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.