Hi sachin,

I did some minor reformatting of your code and used array splices instead of your rather long assignments

You already heared of array splices?

I changed what Corion suggested and also moved the prepare statement out of the loop, because this is the sense of a prepare statement

I also declared a new srray, because naming something like $column_1 (or $first_column and so on) always looks like an array structure.

But maybe this naming has to do with your contrieved example.

use strict;
use warnings;;

my $dir     = "tt";
my $date    = "dd";
my $brnchid = "kk";
my $path    = join "/", $dir, $date;
my $dbfile  = "xxx.xx.xx.xx";

my $dsn      = "dbi:Oracle:host=$dbfile";
my $user     = "ma";
my $password = "mama";
my $dbh      = DBI->connect(
    'dbi:Oracle:host=xx.xx.xx.xx;sid=orcl;port=1521;SERVER=POOLED',
    $user,
    $password,
    {   PrintError       => 1,
        RaiseError       => 1,
        AutoCommit       => 1,
        FetchHashKeyName => 'NAME_lc',
        TraceLevel       => 4,
    }
) or die "Cannot connect to Database: $DBI::errstr\n";

chdir($path);

open( my $fh, '< nwsa.txt' )
    or die "Could not open file  $!";

my $sql = "INSERT INTO nwsa (code_id,name_code,inr_col,out_col,brnch_i
+d) VALUES (?,?,?,?,?)";
print "$sql\n";
my $sth = $dbh->prepare($sql);

while ( my $current_row = <$fh> ) {
    if ( $current_row =~ /^[AL]/ ) {
        my @sachin = split //, $current_row;
        my @column;                    # a fresh array for each row
        $column[1] = join( "", @sachin[0,6] );
        $column[2] = join( "", @sachin[7,77] );
        $column[3] = join( "", @sachin[85,101] );
        my @newdigit = split /[,]+/, $column[3];
        my $string = join( '', map {"$_"} @newdigit );
        my $Receipt_Amount = ( $string * 100 ) / 100;
        print "$Receipt_Amount\n";
        $column[4] = join( "", @sachin[106,126] );
        my @newdigit1 = split /[,]+/, $column[4];
        $string = join( '', map {"$_"} @newdigit1 );
        my $Receipt_Amount1 = ( $string * 100 ) / 100;
        print "$Receipt_Amount1\n";

        print "$column[1],", "$column[2],", "$Receipt_Amount,", "$Rece
+ipt_Amount1,", "$date,", "$brnchid \n";
        my $rc = $sth->execute( $column[1], $column[2], $Receipt_Amoun
+t, $Receipt_Amount1, $brnchid );
        #$sth->finish();               # counterproductive esp. when m
+oving prepare statement out of while loop
    }
}
$dbh->disconnect();
close($fh);

[download]

Hope this will work as intended, I have no Oracle host to work with.

Cheers Bedani

In reply to Re^2: not able to insert data in database using perl DBI by Anonymous Monk
in thread not able to insert data in database using perl DBI by sachin raj aryan

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.