Use map if you want to create a new list from an old one. To change an existing array, use for instead.

Also, (#)? would be more readable as (#?) , as you want to match the octothorpe if present, not to match it always, but maybe zero times.

You correctly used a lexical filehandle for the input. Use a lexical filehandle for the output, too.

The preferred way of processing files, though, is to read them line by line if possible. You need to print to a temporary file, as you can't read a file and print to it at the same time.

#!/usr/bin/perl use warnings; use strict; my $file = 'C:/Windows/System32/drivers/etc/hosts'; my %replace = ( '#' => q(), '' => '#' ); open my $In, '<', $file or die $!; open my $Out, '>', "$file.new" or die $!; while (<$In>) { s/(#?)(10\.10\.1\.2)/$replace{$1}$2/; print {$Out} $_; } close $Out or die $!; rename "$file.new", $file or die $!;

($q=q:Sq=~/;[c](.)(.)/;chr(-||-|5+lengthSq)`"S|oS2"`map{chr |+ord }map{substrSq`S_+|`|}3E|-|`7**2-3:)=~y+S|`+$1,++print+eval$q,q,a,

In reply to Re: Read in hostfile, modify, output by choroba
in thread Read in hostfile, modify, output by razmeth

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.