You're testing $1, but your error message contains $_[0] as the filename. Which one is it you want?

Let me suggest that you output the file name in your error message. If you're really intent on (re-)using $1, then you should also pass $1 to your subroutine read_file.

Personally, I wouldn't reuse $1 outside of the subroutine where it is set through a match:

my $includepath="somefolder/somefolder/";
$html =~ s/<!--#include file="([^"]+)"-->/&add_template($includepath.$
+1)/gexi;
print $html;

sub add_template{
        my( $filename ) = @_;
        if(!-f $filename){
             return "Could not include template '$filename' because: N
+O  FILE"
        }elsif(!-r $1){
             return "Could not include template '$filename' because: N
+O ACCESS TO FILE";
        }else         {
         return read_file($filename);
        }
}

[download]

Also consider why you're testin the existence and readability yourself? Personally, I would let read_file fail and output the error message from it instead of doing manual error checking.

In reply to Re^3: displaying html file in the browser using perl by Corion
in thread displaying html file in the browser using perl by tsdesai

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.