my $test = 'a' if shift;

This line clearly is doing too much at once. It can be broken down (as has already been explained) to

• my $test; and
• $test = 'a' if shift;

This may be you fooling around with Perl's syntax, or it may be a simplification of a real-world problem, but I'm hoping it's just fooling around.

Better would be

sub test
{
  my $arg = shift;
  my $test = '';

  defined $arg and $test = 'a';
  $test .= 'b';

  return $test;
}
[download]

This is much longer, but I've removed the post-fix statement (personal preference); I have explicitly initialized $test; and it's now clear that the steps are 1) initialize test; 2) set test to 'a' if there was an argument; 3) append 'b' to test; and 4) explicitly return the test value.

And the best part .. when you run it, you now get

b
b
[download]

as I expect you wanted.

My comments:

• I'm not a fan of post-fix -- I have to read it more than once to be sure I'm getting the right meaning.
• I don't mind writing stuff out so it takes a little longer to read, if the meaning or intent of the code is clearer.
• Yes, the explicit return is unnecessary in this context, but this then relies on the concatenation operation being the last line of code. Add something unrelated as the last statement, and suddenly the routine's returning an unexpected result.
• Code clarity matters. If you have to go back to some of your own code after six months and it takes time for you to decipher what's going on .. that's bad. Just make it clear, for your own sake, and for anyone else who has to read your code.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.